Support GPU format/colourspace conversion #11337
Open
+150
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaedtler
force-pushed
the
rodney/gpu-colour-conversion
branch
3 times, most recently
from
033130d to
decb9f6
Compare
Lain-B
approved these changes
Oct 5, 2024
|
Haven't tested it but this seems straight forward and simple. |
dsaedtler
force-pushed
the
rodney/gpu-colour-conversion
branch
2 times, most recently
from
91418d6 to
1510213
Compare
dsaedtler
force-pushed
the
rodney/gpu-colour-conversion
branch
2 times, most recently
from
c71b130 to
1f20630
Compare
derrod
reviewed
Oct 22, 2024
dsaedtler
force-pushed
the
rodney/gpu-colour-conversion
branch
2 times, most recently
from
7117695 to
a6e19f0
Compare
dsaedtler
force-pushed
the
rodney/gpu-colour-conversion
branch
3 times, most recently
from
381132f to
1ad6865
Compare
dsaedtler
force-pushed
the
rodney/gpu-colour-conversion
branch
from
1ad6865 to
3614283
Compare
RytoEX
requested changes
Jan 23, 2025
Unlike obs_nv12/p010_tex_active() this accurately reflects the texture availability in the mix associated with the encoder.
Use the recently added `obs_encoder_video_tex_active()` API for AMD AMF-based encoders, similar to the recent commit for obs-nvenc. This allows the OBS canvas to use non-NV12 pixel formats (such as I444) while the multitrack video encoders will use NV12 or P010 textures converted using the GPU.
Also sets Rec. 709/limited defaults for multitrack output.
dsaedtler
force-pushed
the
rodney/gpu-colour-conversion
branch
from
7a35445 to
28858b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends GPU scaling to also handle colourspace or format conversions to enable shared-texture encoding with heterogenous output formats.
Motivation and Context
#11336 falls back to shared memory encoders, which are less efficient, this aims to fix that by extending the conversion capabilities.
In theory this would also allow recording HDR locally and streaming SDR, among other use cases that people might have.
Will need some additional discussion related to function naming and implemenation of the new texture availability check.
How Has This Been Tested?
Streamed to Twitch while recording 444 locally as well as streaming SDR while recording HDR locally.
This is part of the closed beta Twitch Enhanced Broadcasting build and seems to work fine so far.
Types of changes
Checklist: